Removed redundant if clause in getAutoClass() #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clause `else if(extension_loaded('pdo_sqlite') && is_writeable($path))` is redundant, because this code path is only executed, if $path is not writeable. So the right part of that and expression is always false and thus the driver will never be set to sqlite.
Additionally #57 claims, that sqlite is a lot slower than files so there is no point in preferring this driver over files by default.
Member
|
agree, if path is writeable then files is set already, so if files is not set, then path is not writeable the PDO sqlite will never get to TRUE. and SQLite is slower than files, so I agree to remove it out of autoClass. |
khoaofgod
added a commit
that referenced
this pull request
Mar 25, 2015
Removed redundant if clause in getAutoClass()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clause
else if(extension_loaded('pdo_sqlite') && is_writeable($path))is redundant, because this code path is only executed, if $path is not writeable. So the right part of that and expression is always false and thus the driver will never be set to sqlite.Additionally #57 claims, that sqlite is a lot slower than files so there is no point in preferring this driver over files by default.