-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to webpack #68
Conversation
Awesome! I'm sure this is gonna be a hell of conflicts and maintenance until merged, but this is absolutely the way MPW should evolve towards. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Depends installs fine, the build is running fine.
Tested basic transactions sending/stake/unstake
Style nits on spacing as we're getting ready to have linting run by GitHub etc but otherwise great job!
I did not comment in regard to most spacing just because of seeing what others say
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And lastly the webpack.config.js is being ready as mixed with tabs and spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK: tested with basically every single existing button of MPW (except for ledger) , awesome PR this will finally let us to start with shield transactions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 soft utACK, I've done a brief review of the entire set of changes, all seems fine and dandy, I highly appreciate the new file structure, lint style and module system, I will do actual code testing once the PR is 100% complete (i.e: once this includes the UTXO API merge, and no conflicts with master).
Amazing work. 💪 💜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! 🎉
✔️ - Wallet Creation, Export and Import (Seed and Legacy).
✔️ - Send, Receive, Delegate, Undelegate.
✔️ - Cold Rewards recognised (Mainnet Tested Only).
✔️ - Masternode creation & start.
✔️ - All Settings.
✔️ - Mainnet and Testnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK: tested again and it works fine, really good work :)
Abstract
Moves to webpack. This deletes all of the external libraries to the repo (this makes it way easier to audit the code as well as updating libraries).
Convertes all of the existing code to ES6 modules. exported things in
index.js
will be available under the MPW namespace. This is only to access them in HTML, the namespace shouldn't be used in regular javascript.To install dependencies:
npm i
. To run webpack:npm run build
. Then, the dist folder should be hosted/opened locally.In a future PR the global.js file should be split in smaller files.
What features or improvements were added?
How does this benefit users?