Fix web metadata #79
Merged
Fix web metadata #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSKitty
added
Bug
Liquid369
approved these changes
Feb 4, 2023
There was a problem hiding this comment.
tACK 397e09b
I have compared the two.
This works fine but I do not have an opinion in regard to the /assets/ being kept.
In general, seems like it would make sense to keep /assets/ but unsure if it really makes a difference
While testing the MN List work I am doing saw these in the console as errors so looks good overall
Luke-Larsen
approved these changes
Feb 5, 2023
There was a problem hiding this comment.
tACK 397e09b
I have compared the two just like liquid, I think the changes and moving the favicon out of assets is good as some older browsers and systems default to it being in root. Everything else looks fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Since the merge of #68, some of MPW's metadata (icons, banner) were "lost" as the structure of the files was changed without corrections.
My edit simply removes the path "hardcoding" and makes them relative to the root directory.
Testing
Simply check the metadata display of our live MPW.
Against the metadata display of my modified MPW.
You'll notice the missing brand image from the live site; this should also apply to Discord, but beware that Discord caches this stuff, so even an update MPW site may take some time before Discord registers the new metadata.
Note:
I'm unsure if this is the best fix; since MPW is now essentially "flat" in it's file structure, this probably doesn't index well by search engines.
Should our images be in a public-facing
/assets/directory? Icons? etc?Open to suggestions, but if none are made, this small fix will suffice.