Tidy up transaction.js #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSKitty
added
Documentation
JSKitty
previously approved these changes
Feb 27, 2023
There was a problem hiding this comment.
tACK, tested with over 1000 UTXOs in many different transaction styles (Send - Delegate - Undelegate) 🎉
Extremely clean - great to finally have our last messy part of 'coin control' centralised in to a single transaction function finally, massive code reduction there alone.
Great job! 🚀 🔥
Co-authored-by: JSKitty <jskitty@protonmail.com>
Merged
JSKitty
approved these changes
Feb 28, 2023
panleone
approved these changes
Feb 28, 2023
Duddino
added a commit
to Duddino/MyPIVXWallet
that referenced
this pull request
Mar 9, 2023
* Rewritten delegate, undelegate, sendTx * Now they work * Ran prettier * Added error checking * Restored wallet.js since it will be fixed in PIVX-Labs#87 * Added jsdoc comments * Apply suggestions from code review Co-authored-by: JSKitty <jskitty@protonmail.com> --------- Co-authored-by: JSKitty <jskitty@protonmail.com>
Duddino
added a commit
to Duddino/MyPIVXWallet
that referenced
this pull request
Mar 9, 2023
* Rewritten delegate, undelegate, sendTx * Now they work * Ran prettier * Added error checking * Restored wallet.js since it will be fixed in PIVX-Labs#87 * Added jsdoc comments * Apply suggestions from code review Co-authored-by: JSKitty <jskitty@protonmail.com> --------- Co-authored-by: JSKitty <jskitty@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Tidy up transaction.js
What does this PR address?
This PR cleans up transaction.js halving the lines of copy-pasted code and removing unused functions
How does this benefit users?
The code is easier to audit and edit