Ledger fix #87
Merged
Ledger fix #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 23, 2023 08:15
Duddino
pushed a commit
to Duddino/MyPIVXWallet
that referenced
this pull request
Feb 23, 2023
JSKitty
added
Bug
JSKitty
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
tACK! Tested both the bug itself (Primary Production) and this PR's fix, working a treat.
Good catch! 🎉
PalmTreeVI
approved these changes
Feb 27, 2023
JSKitty
added a commit
that referenced
this pull request
Mar 1, 2023
* Rewritten delegate, undelegate, sendTx * Now they work * Ran prettier * Added error checking * Restored wallet.js since it will be fixed in #87 * Added jsdoc comments * Apply suggestions from code review Co-authored-by: JSKitty <jskitty@protonmail.com> --------- Co-authored-by: JSKitty <jskitty@protonmail.com>
JSKitty
added a commit
that referenced
this pull request
Mar 5, 2023
* [JS] Remove unused lines * [CSS] Change Dashboard height * [CSS] Input style changes * [CSS] Add medium button * [CSS] Change padding in buttoni-text * [CSS] Change input outline color * [CSS] New transfer menu * [Transfer] New transfer menu * [Dashboard] Replace withdraw button functionality * [Navbar] Remove `sent` menu * [Send] Remove old send page * [JS + HTML] Forgot to add `toggleBottomMenu` * Add conversion currency, payment processor, fixes * i18n cleanup * Remove residue TX 'Continue' logic * Fix export oversight bug from #87 * Add Duddino's suggestions * Payment Requests cleanup * [General] Bottom menu background --------- Co-authored-by: JSKitty <jskitty@protonmail.com>
Duddino
added a commit
to Duddino/MyPIVXWallet
that referenced
this pull request
Mar 9, 2023
* Rewritten delegate, undelegate, sendTx * Now they work * Ran prettier * Added error checking * Restored wallet.js since it will be fixed in PIVX-Labs#87 * Added jsdoc comments * Apply suggestions from code review Co-authored-by: JSKitty <jskitty@protonmail.com> --------- Co-authored-by: JSKitty <jskitty@protonmail.com>
Duddino
added a commit
to Duddino/MyPIVXWallet
that referenced
this pull request
Mar 9, 2023
* Rewritten delegate, undelegate, sendTx * Now they work * Ran prettier * Added error checking * Restored wallet.js since it will be fixed in PIVX-Labs#87 * Added jsdoc comments * Apply suggestions from code review Co-authored-by: JSKitty <jskitty@protonmail.com> --------- Co-authored-by: JSKitty <jskitty@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small oversight caused by #73 broke ledger support, this fixes it and removes unused dom objects