Skip to content

Avoid iterating prototype properties in trimUndefinedProperties #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2025
Merged

Avoid iterating prototype properties in trimUndefinedProperties #602

merged 1 commit into from
Sep 4, 2025

Conversation

@PLhery
Copy link
Owner

@PLhery PLhery commented Sep 4, 2025 •
edited
Loading

Created by codex

Summary

  • Ensure trimUndefinedProperties only iterates own keys to avoid touching prototype chain
  • Document trimUndefinedProperties behavior and add example
  • Add unit test confirming prototype properties are untouched

Testing

  • npm run mocha test/helpers.test.ts

@PLhery PLhery merged commit 450e1f2 into master Sep 4, 2025
1 check passed
@PLhery PLhery deleted the codex/modify-object-iteration-in-helpers.ts branch September 4, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PLhery