Changes to support OpenEXR 3.0. #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-lipka
suggested changes
Jul 2, 2021
| unsigned long tellp() | ||
| { | ||
| unsigned long pos = os.tellg(); | ||
| if((int) pos == -1) |
Contributor
There was a problem hiding this comment.
While you're at it, all unsigned long in the file should be considered a bug. They should either be POV_LONG (v3.7) / POV_OFF_T (v3.8) or whatever we'll be using instead of Int64.
Same goes for the comparison with -1 here and further below: There's a bug lurking in there as well, and it should instead be something like if(pos == POV_LONG(-1)) (or correspondingly for v3.8).
c-lipka
approved these changes
Jul 8, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to support OpenEXR 3,0