refactored POST in RateProjects #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh1nkey
commented
Feb 29, 2024
|
|
||
| class ProjectScoreCreateSerializer(serializers.ModelSerializer): | ||
| def __init__(self, *args, **kwargs): | ||
| self.criteria_to_get = kwargs.pop("criteria_to_get", None) |
Member
Author
There was a problem hiding this comment.
для этого не было особых причин, но я подумал, что так передавать аргумент в классе сериалайзера будет удобно
sh1nkey
commented
Feb 29, 2024
| model = ProjectScore | ||
| fields = ["criteria", "user", "project", "value"] | ||
| fields = ("criteria", "user", "project", "value") | ||
| validators = [] |
Member
Author
There was a problem hiding this comment.
потому что иначе у меня будет автоматическая проверка на unique_together, а это мне не нужно, потому что дальше по коду будет обновление/создание оценок. если тут вылезет ошибка, то create_in_bulk обновить их не сможет
sh1nkey
commented
Feb 29, 2024
| fields = ("criteria", "user", "project", "value") | ||
| validators = [] | ||
|
|
||
| def get_queryset(self): |
Member
Author
There was a problem hiding this comment.
сериалайзер подгружает данные, оказывается. скорее всего, для каждого объекта в списке отдельно. это не круто. я не доверяю ему, поэтому сделал по своему
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
провёл рефакторинг POST запроса для создания оценок проектов по критериям