Skip to content

feat: support target option#140

Merged
max-sixty merged 8 commits into
PRQL:mainfrom
eitsupi:target-option
Mar 9, 2023
Merged

feat: support target option#140
max-sixty merged 8 commits into
PRQL:mainfrom
eitsupi:target-option

Conversation

@eitsupi
Copy link
Copy Markdown
Member

@eitsupi eitsupi commented Mar 8, 2023

  • Generate DuckDB SQL in Pandas integration.
  • Targets can be specified with the new option of prql Ipython magic.

Copy link
Copy Markdown
Member

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks a lot.

I left one comment re the readme

Comment thread README.md Outdated
Comment thread pyprql/tests/test_magic.py Outdated
@eitsupi
Copy link
Copy Markdown
Member Author

eitsupi commented Mar 9, 2023

I fixed it, and would appreciate it if you could merge this before prql-python version 0.6.0.

@max-sixty
Copy link
Copy Markdown
Member

Thanks a lot @eitsupi !

@max-sixty max-sixty merged commit 393bc65 into PRQL:main Mar 9, 2023
@max-sixty
Copy link
Copy Markdown
Member

Would you be up for adding this to the changelog?

@eitsupi eitsupi deleted the target-option branch March 9, 2023 12:52
@eitsupi
Copy link
Copy Markdown
Member Author

eitsupi commented Mar 9, 2023

Hmmm, I looked into this and it seems that perhaps the GitHub Actions were automatically updating Changelog?
ab75b6e

Related to this, v0.5.14 has a tag but seems to have failed to release.
v0.5.14 is not available on PYPI.

Since you gave me merge rights, I may be able to undertake the release work.

@max-sixty
Copy link
Copy Markdown
Member

That would be really helpful if you'd be up for resolving that.

I did some work on it a while ago — there used to be a very sophisticated release workflow, but it needed some work and so I simplified it — but I don't think it's in a perfect state.

Let me know if you make any progress in the next few days / whether there's anything I can do to make that easier for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants