feat: prepare for next release (based on prql-python 0.6.0)#142
Conversation
|
By the way, I just realized the other day that python-semantic-release only lists "feat" and "fix" types commits in Changelog for now, but I forgot that and used "build" in #141... |
|
Current changelog. $ semantic-release changelog --unreleased
### Feature
* Support target option ([#140](https://github.com/eitsupi/pyprql/issues/140)) ([`393bc65`](https://github.com/eitsupi/pyprql/commit/393bc65690fc4e31d863708e1564a68225c7624d))
* Upgrade to prql-python 0.4 ([#129](https://github.com/eitsupi/pyprql/issues/129)) ([`ba5afa8`](https://github.com/eitsupi/pyprql/commit/ba5afa80fb27b8d998c39789f110c4e1ce1904de))
### Fix
* Manually fix version of pyproject.toml ([`6b5d43d`](https://github.com/eitsupi/pyprql/commit/6b5d43d5bede60f83e30ff1543a96f8421bfb7e1))
### Documentation
* Fix docs build ([#118](https://github.com/eitsupi/pyprql/issues/118)) ([`c7e7365`](https://github.com/eitsupi/pyprql/commit/c7e73656c27b7891dc61053b5cca4b64c299e555)) |
|
Sorry, please let the type of commit by this PR be "feat" in order to have the prql-python version listed in the Changelog....... |
|
Looking good! Thank you v much @eitsupi |
|
The generation of the changelog seems to have worked, but the commit failed and the release also failed. I think it is because the main branch is a protected branch with status checks set. |
|
Hmmm. I'll try disabling the check... |
|
Sorry, I made another commit (#143), so re-running the workflow also failed....... I will try another PR. |
|
OK! BTW if there are easier ways to do things like releases and changelogs, and you'd like to make changes — I have no loyalty to the current system :) |
|
Yes, when weighing branch protection vs. current workflow, I believe accident prevention through branch protection is more important...... While the automatic generation of changelogs is useful, it would make sense to move to a new workflow that not using automatic commits, since the user can run |
|
I agree! (I think it might be possible to do both, by using a token and giving |
|
Anyway, it seems that the workflow failed again because of the protected branch (manual execution didn't help). In https://github.com/python-gitlab/python-gitlab, the workflow on the main branch seems to work well despite being protected, so perhaps there is a way. |
|
OK, I tried removing all protections and running manually... https://github.com/PRQL/pyprql/actions/runs/4396531246 |
|
Thank you. |
|
No prob, thank you very much for helping! (FYI I'm off for the night, as ever feel free to do whatever you think is best, happy to help tomorrow) |
Based on the discussion on #140, preparing for the next release.
A little research shows that python-semantic-release is used in the following repository and will probably work.......
https://github.com/python-gitlab/python-gitlab/blob/d387d91401fdf933b1832ea2593614ea6b7d8acf/.github/workflows/release.yml