perf(angular): upgraded to Angular v18 latest stable version #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Walkthrough
This update modernizes the Angular project's configuration and dependencies. It upgrades all Angular-related packages and tools to version 18.x, updates TypeScript and ESLint dependencies, and refactors HTTP client provisioning in Angular modules to use the new `provideHttpClient` API. Build configuration files are updated to new Angular conventions, and minor CSS import path adjustments are made.
## Changes
| File(s) | Change Summary |
|-------------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `angular.json` | Updated build configuration: switched builder to `application`, changed `outputPath` structure, moved `main` entry, removed some build options, and replaced `browserTarget` with `buildTarget` in serve/extract-i18n targets. |
| `package.json` | Upgraded all Angular packages and related dependencies to 18.x; updated TypeScript, ESLint, and related devDependencies to newer versions; added `ejs` package. |
| `tsconfig.json` | Removed `downlevelIteration` and `allowSyntheticDefaultImports` compiler options. |
| `src/app/app-provider-admin/provider-admin/configurations/questionnaire/add-questionnaire/add-questionnaire.component.css` | Removed tilde (~) from material-design-icons CSS import path. |
| `src/styles.css` | Removed tilde (~) from two commented-out CSS import statements. |
| `src/app/app-provider-admin/provider-admin/provider-admin.module.ts`<br>`src/app/app-provider-admin/super-admin/super-admin.module.ts`<br>`src/app/app.module.ts` | Replaced `HttpClientModule` import with `provideHttpClient(withInterceptorsFromDi())` in providers for HTTP client provisioning; in `super-admin.module.ts`, also exported `SuperAdminComponent`. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant AppModule
participant ProviderAdminModule
participant SuperAdminModule
participant AngularHttpClient
AppModule->>AngularHttpClient: provideHttpClient(withInterceptorsFromDi())
ProviderAdminModule->>AngularHttpClient: provideHttpClient(withInterceptorsFromDi())
SuperAdminModule->>AngularHttpClient: provideHttpClient(withInterceptorsFromDi())
note over AppModule,SuperAdminModule: HTTP interceptors are registered via DIAssessment against linked issues
Possibly related issues
Suggested reviewers
Poem
|
Author
|
@drtechie Could you please review this ! |
drtechie
requested review from
devikasuresh20,
helenKaryamsetty and
snehar-nd
and removed request for
devikasuresh20 and
helenKaryamsetty
Member
|
Hi @snehar-nd can you run this locally and see if everything is working fine? |
|
Contributor
@drtechie yes, It is working fine in locally, |
Author
|
@snehar-nd @drtechie should I raise similar PR's on the other issues to update the Angular and Packages versions assigned to me then ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Description
GitHub Issue: Fixes PSMRI/AMRIT#9
ng updatewithout force was implementedtypescriptversion was upgraded to5.4.5from5.1.3to support Angular v18✅ Type of Change
ℹ️ Additional Information
Testing was performed by checking :
ng servesuccessfully loading the sitenpm run build-cisuccessfully building the UI-repo-- Screenshots for the same are below
Screenshots
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Chores