Skip to content

🩹 [Patch]: Strong type GitHubContext properties #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Dec 14, 2024
Merged

🩹 [Patch]: Strong type GitHubContext properties #204

merged 23 commits into from
Dec 14, 2024

Conversation

@MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Dec 14, 2024 •
edited
Loading

Description

  • Changed the types of
    • ApiBaseUri from string to uri
    • TokenExpirationDate from string to datetime
  • Added Assert-GitHubContext call to validate the authentication type is App.

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Marius Storhaug and others added 20 commits December 13, 2024 01:00
examples
b452f31
@MariusStorhaug
Move examples
885d09a
@MariusStorhaug
Add a GitHub AuthType Enum
531bca2
@MariusStorhaug
Add GitHubAuthType data type on GitHubContext.AuthType
16835a7
@MariusStorhaug
Use GitHubAuthType on Assert-GitHubContext
ba99044
@MariusStorhaug
Add Assert-GitHubContext on Get-GitHubAppWebhookConfiguration
d534a61
@MariusStorhaug
Rename AuthType
7d93e87
@MariusStorhaug
Introduce UserGitHubContextAuthAppType enum and update DeviceFlowType…
a72d31c 
… to use it
@MariusStorhaug
Change ApiBaseUri type from string to uri in GitHubContext class
00c9b10
@MariusStorhaug
Refactor GitHubContext to use enums for Type, AuthType, and TokenType…
4728a22 
…; update related functions for consistency
@MariusStorhaug
Add .ToString() for enum values
c45a1c8
@MariusStorhaug
Fix
18f050b
@MariusStorhaug
Refactor GitHub App scripts to use Assert-GitHubContext for App authe…
2027edb 
…ntication
@MariusStorhaug
revert
b24bfd6
@MariusStorhaug
Refactor Get-GitHubContext and Set-GitHubContext to use string litera…
f1b4506 
…ls for context types
@MariusStorhaug
Refactor GitHub App scripts to streamline context resolution and auth…
e2872c7 
…entication
@MariusStorhaug
Refactor Set-GitHubContext to improve context type handling and verbo…
929261b 
…sity logging
@MariusStorhaug
Refactor context type annotations to use 'object' for improved flexib…
1f31463 
…ility
@MariusStorhaug
Merge branch 'main' of https://github.com/PSModule/GitHub into classc…
ed10aac 
…hanges
@MariusStorhaug
Update output type annotations to use 'GitHubContext' for improved ty…
e780683 
…pe safety
@MariusStorhaug MariusStorhaug requested a review from a team as a code owner December 14, 2024 00:03
@MariusStorhaug MariusStorhaug merged commit 2bc08e7 into main Dec 14, 2024
6 checks passed
@MariusStorhaug MariusStorhaug deleted the uriAoiBaseURI branch December 14, 2024 20:49
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2024

Module [GitHub - 0.11.9] published to the PowerShell Gallery.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2024

GitHub release for GitHub v0.11.9 has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

GitHub PowerShell Module
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MariusStorhaug