Skip to content

Conversation

@MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Dec 23, 2024

Description

This pull request includes significant changes to the Get-GitHubEmoji function in src/functions/public/Emojis/Get-GitHubEmoji.ps1 and updates to the corresponding tests in tests/GitHub.Tests.ps1. The changes improve parameter handling, enhance error handling, and update test cases.

Improvements to Get-GitHubEmoji function:

  • Added DefaultParameterSetName to CmdletBinding to ensure the correct parameter set is used by default.
  • Updated the Destination parameter to be mandatory when using the 'Download' parameter set.
  • Enhanced the response handling by using Select-Object -ExpandProperty Response for cleaner code.
  • Improved the download logic with better error handling and retry mechanisms for failed downloads.

Updates to test cases:

  • Changed the destination for downloading emojis in tests from $env:TEMP to $Home to ensure compatibility across different environments. [1] [2] [3] [4]

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug requested a review from a team as a code owner December 23, 2024 22:48
@MariusStorhaug MariusStorhaug self-assigned this Dec 23, 2024
@MariusStorhaug MariusStorhaug merged commit 33908ef into main Dec 24, 2024
6 checks passed
@MariusStorhaug MariusStorhaug deleted the EmojiFix branch December 24, 2024 12:18
@github-actions
Copy link
Contributor

Module [GitHub - v0.11.27] published to the PowerShell Gallery.

@github-actions
Copy link
Contributor

GitHub release for GitHub v0.11.27 has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants