Skip to content

[Enhancement] Auth - Move metadata to the tokens metadata in the secret store #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 27, 2023
Merged

[Enhancement] Auth - Move metadata to the tokens metadata in the secret store #25

merged 14 commits into from
Sep 27, 2023

Conversation

@MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Sep 27, 2023 •
edited
Loading

  • Fixes [Enhancement] Auth - Move metadata to the tokens metadata in the secret store #24
    • Moved all variables/data and "profile data" to the metadata of the SecretStore secret.
      • Access and Refresh tokens get stored as separate secrets in the vault.
      • Expiration dates for the two gets stored as metadata on the respective secret.
      • All other data like token type, repo, org, api version etc are stored on the metadata of the accesstoken as its similar to a profile.

@MariusStorhaug MariusStorhaug linked an issue Sep 27, 2023 that may be closed by this pull request
[Enhancement] Auth - Move metadata to the tokens metadata in the secret store #24
Closed
@MariusStorhaug MariusStorhaug changed the title 24 enhancement auth move metadata to the tokens metadata in the secret store [Enhancement] Auth - Move metadata to the tokens metadata in the secret store Sep 27, 2023
@MariusStorhaug MariusStorhaug marked this pull request as ready for review September 27, 2023 17:09
@MariusStorhaug MariusStorhaug added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 0f681fc Sep 27, 2023
@MariusStorhaug MariusStorhaug deleted the 24-enhancement-auth-move-metadata-to-the-tokens-metadata-in-the-secret-store branch September 27, 2023 17:10
@MariusStorhaug MariusStorhaug self-assigned this Oct 4, 2023
@MariusStorhaug MariusStorhaug added the feature New feature label Oct 4, 2023
@MariusStorhaug MariusStorhaug added this to the v0.2 milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@MariusStorhaug MariusStorhaug

Labels

feature New feature

Projects

GitHub PowerShell Module
Archived in project

Milestone

v0.2

Development

Successfully merging this pull request may close these issues.

[Enhancement] Auth - Move metadata to the tokens metadata in the secret store

2 participants

@MariusStorhaug