🩹 [Patch]: Improve the handling of wildcard names in Get-GitHubEnvironment
#329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prove environment retrieval logic in `Get-GitHubEnvironment`
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- src/functions/private/Environments/Get-GitHubEnvironmentByName.ps1: Language not supported
- src/functions/public/Environments/Get-GitHubEnvironment.ps1: Language not supported
…d 'Name' parameter and add checks for existing environments
… retrieval of environments with slashes in their names
…arify expected behavior when no environments are retrieved
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (3)
- src/functions/private/Environments/Get-GitHubEnvironmentByName.ps1: Language not supported
- src/functions/public/Environments/Get-GitHubEnvironment.ps1: Language not supported
- tests/Environments.Tests.ps1: Language not supported
github-project-automation
bot
moved this from In Progress
to Done
in GitHub PowerShell Module
MariusStorhaug
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Module GitHub - 0.18.1 published to the PowerShell Gallery. |
|
GitHub release for GitHub v0.18.1 has been created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes updates to the
Get-GitHubEnvironmentandGet-GitHubEnvironmentByNamefunctions, as well as significant changes to theEnvironments.Tests.ps1file to improve test coverage and clarity.Improvements to
Get-GitHubEnvironmentandGet-GitHubEnvironmentByNamefunctions:src/functions/private/Environments/Get-GitHubEnvironmentByName.ps1: Added a try-catch block to handle exceptions and ensure the function returns gracefully in case of errors. [1] [2]src/functions/public/Environments/Get-GitHubEnvironment.ps1: Added logic to handle wildcard characters in environment names, allowing for more flexible environment retrieval.Enhancements to test coverage and clarity:
tests/Environments.Tests.ps1: Refactored test descriptions and contexts for better readability and organization. Tests now cover scenarios such as listing all environments, retrieving specific environments, and handling non-existent environments. [1] [2] [3] [4] [5]Type of change
Checklist