🩹 [Patch]: Add JwtTimeTolerance, dynamically update config and Sodium as a direct dependency
#369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and update context properties in GitHub configuration
There was a problem hiding this comment.
Pull Request Overview
This PR introduces several enhancements including dynamic configuration updates and improved JWT handling along with dependency management improvements.
- Added a configurable JwtTimeTolerance property for JWT generation
- Enhanced configuration handling in the GitHub PowerShell module by dynamically updating context properties
- Updated dependency management, including a new #Requires statement for the Sodium module
Files not reviewed (5)
- src/functions/private/Config/Get-GitHubEnvironmentType.ps1: Language not supported
- src/functions/private/Config/Initialize-GitHubConfig.ps1: Language not supported
- src/functions/public/Apps/GitHub App/Get-GitHubAppJSONWebToken.ps1: Language not supported
- src/functions/public/Secrets/Set-GitHubSecret.ps1: Language not supported
- src/variables/private/GitHub.ps1: Language not supported
…HubSecret function
…on in GitHubConfig class
…unction to clarify output type and properties
MariusStorhaug
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Module GitHub - 0.27.1 published to the PowerShell Gallery. |
|
GitHub release for GitHub v0.27.1 has been created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several updates to improve functionality, maintainability, and configuration flexibility in the GitHub PowerShell module. The most significant changes include adding a new function to determine the GitHub environment type, enhancing context initialization with dynamic property updates, and introducing a configurable JWT time tolerance.
New functionality
Get-GitHubEnvironmentTypefunction to dynamically determine the environment type (e.g., GitHub Actions, Azure Functions, or local) based on environment variables. This replaces the previous static logic.Enhancements to configuration handling
Initialize-GitHubConfigfunction to dynamically add missing default properties to the stored context, ensuring compatibility with future updates.JwtTimeToleranceproperty in theGitHub.DefaultConfigobject to allow configurable time tolerance for JSON Web Token (JWT) generation.Refactoring
EnvironmentTypelogic inGitHub.ps1with a call to the newGet-GitHubEnvironmentTypefunction for better modularity and maintainability.Improvements to JWT handling
Get-GitHubAppJSONWebTokento use the newJwtTimeToleranceproperty for both issued-at (iat) and expiration (exp) times, improving flexibility and time slip.Dependency management
#Requiresstatement toSet-GitHubSecretto ensure the requiredSodiummodule is available, improving reliability.Type of change
Checklist