🌟 [Major]: Process-PSModule v5 #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Phase 0: Research complete (conditional execution, concurrency, authentication) - Phase 1: Design complete (data model, workflow contract, quickstart guide) - Phase 2: Task planning approach documented - Updated agent context with feature information - All constitutional requirements validated
Consolidates separate CI.yml into single workflow.yml with improved efficiency, conditional publishing, and better concurrency management. BREAKING CHANGE: The .github/workflows/CI.yml file has been deleted and its functionality merged into workflow.yml. Consuming repositories must migrate to the new unified workflow structure. - Renamed CI.yml to CI.yml.backup (reference only) - Implemented concurrency groups with auto-cancellation - Added conditional job execution based on PR state - Created comprehensive test suite (52 integration tests, 63 contract tests) - Added migration guide and release notes - Updated documentation with breaking change notice Closes #201
…ts for the unified CI/CD workflow feature. This cleanup reflects the completion of the feature implementation and the transition to a single workflow configuration file, consolidating all functionality and removing the need for separate CI.yml and workflow.yml files.
…d remove obsolete CHANGELOG
…nd clarifying GitHub integration instructions
…or credential handling
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy CI.yml workflow and consolidates functionality into the main workflow.yml file, addressing the dual-maintenance burden described in the unified workflow configuration specification. The changes eliminate the separate CI workflow while preserving all testing capabilities and adding repository linting functionality for pull requests.
Key changes:
- Removed CI.yml workflow entirely and all dependent test workflows
- Added Lint-Repository job to workflow.yml for pull requests
- Enhanced existing workflows with security best practices (persist-credentials: false)
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| specs/001-unified-workflow-config/spec.md | Added comprehensive specification for unified workflow configuration |
| .github/workflows/CI.yml | Removed entire CI workflow file |
| .github/workflows/workflow.yml | Added Lint-Repository job and removed redundant Install-PSModuleHelpers step |
| .github/workflows/Workflow-Test-WithManifest-CI.yml | Removed CI test workflow for manifest testing |
| .github/workflows/Workflow-Test-Default-CI.yml | Removed CI test workflow for default testing |
| .github/workflows/Linter.yml | Added persist-credentials: false for security |
| .github/workflows/Lint-SourceCode.yml | Added persist-credentials and fetch-depth configuration |
| .github/prompts/implement.prompt.md | Updated task tracking and PR description management instructions |
| .github/copilot-instructions.md | Added references to technology-specific instruction files |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…mprove job execution logic
…rmissions for workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request cleans up and consolidates the process into focussing on a single workflow, the
workflow.ymlfile. It also updates some more logic and addresses some security issues for the checkout action.Details
Removed the workflow
CI.ymlwhich has previously been used for nightly runs, checking that the logic works.workflow.ymlto work for the same scenarios replacingCI.ymlfor this usecase.Cleaned up some of the job flow depending on the different scenarios.