-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging fails on current master #7911
Comments
We need to do a pass and get the logger topics list under control. I think we should have a much more limited core set and expand the logger profiles idea. |
We should limit the number of add_topics() based on CONFIG_NFILE_DESCRIPTORS or have logger handle this situation a little more gracefully. Users are able to change the topic list with params or adding a list to the sd card. |
I'll open a PR shortly, but so far I'd propose.
|
We should drop the debug vect stuff by default. GPS as well. We need the task stack info (check out http://review.px4.io) In the old logger I dropped stdin and stdout right before opening the log file. That makes it gracefully. We can log a warning as well. |
I like the idea of profiles more than just dropping the log topics. |
I don't see task_stack_info being used by flight review. Can you confirm @bkueng? Usually I pick up the stack warnings from console messages (via flightreview). |
On a DeltaQuad config:
ping @dagar @LorenzMeier @davids5 @bresch
The text was updated successfully, but these errors were encountered: