Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging fails on current master #7911

Closed
sanderux opened this issue Sep 4, 2017 · 6 comments · Fixed by #7914
Closed

Logging fails on current master #7911

sanderux opened this issue Sep 4, 2017 · 6 comments · Fixed by #7914

Comments

@sanderux
Copy link
Member

sanderux commented Sep 4, 2017

On a DeltaQuad config:

INFO  [mavlink] mode: Config, data rate: 800000 B/s on /dev/ttyACM0 @ 57600B
INFO  [logger] logger started (mode=all)
INFO  [logger] Start file log
ERROR [uorb] mavlink_log advertise failed
ERROR [logger] Failed to register ULog file to the hardfault handler (-24)
ERROR [logger] Can't open log file /fs/microsd/log/sess004/log001.ulg, errno: 24
INFO  [init] Mixer: /etc/mixers/deltaquad.main.mix on /dev/pwm_output0 

ping @dagar @LorenzMeier @davids5 @bresch

@dagar
Copy link
Member

dagar commented Sep 4, 2017

We need to do a pass and get the logger topics list under control.
#7559

I think we should have a much more limited core set and expand the logger profiles idea.

@dagar
Copy link
Member

dagar commented Sep 4, 2017

We should limit the number of add_topics() based on CONFIG_NFILE_DESCRIPTORS or have logger handle this situation a little more gracefully. Users are able to change the topic list with params or adding a list to the sd card.

@dagar
Copy link
Member

dagar commented Sep 4, 2017

I'll open a PR shortly, but so far I'd propose.

  • New profile for extended GPS logging

    • gps_dump, satellite_info
  • Replace rc_channels and input_rc with manual_control_setpoint. It's much more useful for understanding what the controllers are doing and logs QGC gamepad input.

  • Remove debug_key_value, debug_value, debug_vect or add to another profile.

  • New profile for things like att_pos_mocap, vehicle_vision_attitude, vehicle_vision_position?

  • Remove task_stack_info? I don't think it's used.

  • Drop differential_pressure logging by default (could be yet another profile).

  • We could get into differenent sets for FW/MC/VTOL if needed.

@LorenzMeier
Copy link
Member

We should drop the debug vect stuff by default. GPS as well. We need the task stack info (check out http://review.px4.io)

In the old logger I dropped stdin and stdout right before opening the log file. That makes it gracefully. We can log a warning as well.

@TSC21
Copy link
Member

TSC21 commented Sep 4, 2017

I like the idea of profiles more than just dropping the log topics.

@dagar
Copy link
Member

dagar commented Sep 4, 2017

I don't see task_stack_info being used by flight review. Can you confirm @bkueng?

Usually I pick up the stack warnings from console messages (via flightreview).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants