-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add param to adjust motor ordering #9544
Conversation
Useful for 4-in-1 ESCs such as the Hobbywing XRotor Micro 40A 4in1 where the FC can be directly plugged on top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok as MVP, but already clear right now that this will be hard to maintain. Let's get it in under the assumption that we will only ever need it for racing quads.
The main issue I see with this is that it breaks the generated metadata that we could be using within QGC for airframe setup, motor testing, etc. There's also no reason it needs to be FMU specific, which we'd mostly get for free if handled by a separate mixer or with this same logic in the MulticopterMixer itself. |
I've seen a very useful solution on a different flight controller (I think it was some DJI Naza):
This helps a lot in the building process because you don't have to worry which one you plug where on the board let alone looking up some hardcoded non-intuitive number scheme online. |
Motor test (integrated with QGC) is a frequent request. It would be great to finally get it in place, and I think we almost have most of the pieces. The only reason I haven't already implemented what's missing PX4 side is I haven't figured out a good workflow with respect to arming and general safety. MAV_CMD_DO_MOTOR_TEST is the Mavlink command which QGC already supports. I think we should have some kind of special arming state for this that the user has to enter before these commands are respected. I also want it implemented more like a dead man's switch, perhaps requiring the user to hold the slider in QGC which will then continuously send the test value, rather than sending it once to start, and once to stop. Thoughts? |
makes sense
you mean for the case where connection is lost in the moment something bad happens? Command stream should be necessary and I think holding some key or button to keep it the motor test running would definitely increase safety. And as I wrote I would support a short motor twitch. |
Useful for 4-in-1 ESCs such as the Hobbywing XRotor Micro 40A 4in1 where the FC can be directly plugged on top.