Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add param to adjust motor ordering #9544

Merged
merged 1 commit into from
May 28, 2018
Merged

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented May 28, 2018

Useful for 4-in-1 ESCs such as the Hobbywing XRotor Micro 40A 4in1 where the FC can be directly plugged on top.

Useful for 4-in-1 ESCs such as the Hobbywing XRotor Micro 40A 4in1
where the FC can be directly plugged on top.
Copy link
Member

@LorenzMeier LorenzMeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok as MVP, but already clear right now that this will be hard to maintain. Let's get it in under the assumption that we will only ever need it for racing quads.

@LorenzMeier LorenzMeier merged commit 4f1c01d into master May 28, 2018
@LorenzMeier LorenzMeier deleted the motor_ordering_param branch May 28, 2018 06:37
@dagar
Copy link
Member

dagar commented May 28, 2018

The main issue I see with this is that it breaks the generated metadata that we could be using within QGC for airframe setup, motor testing, etc.

image

There's also no reason it needs to be FMU specific, which we'd mostly get for free if handled by a separate mixer or with this same logic in the MulticopterMixer itself.

@MaEtUgR
Copy link
Member

MaEtUgR commented Dec 6, 2018

I've seen a very useful solution on a different flight controller (I think it was some DJI Naza):

  • You hook up all the motors to any of the available output ports
  • You open the UI and select what type of frame you have
  • You run motor tests which are by default just small twitches to have it safe because some people leave on their propellers no matter what you tell them.
  • For each motor that twitches you select which number of motor that is according to the airframe picture.

This helps a lot in the building process because you don't have to worry which one you plug where on the board let alone looking up some hardcoded non-intuitive number scheme online.

@dagar
Copy link
Member

dagar commented Dec 6, 2018

Motor test (integrated with QGC) is a frequent request. It would be great to finally get it in place, and I think we almost have most of the pieces.

The only reason I haven't already implemented what's missing PX4 side is I haven't figured out a good workflow with respect to arming and general safety.

MAV_CMD_DO_MOTOR_TEST is the Mavlink command which QGC already supports.
https://mavlink.io/en/messages/common.html#MAV_CMD_DO_MOTOR_TEST

I think we should have some kind of special arming state for this that the user has to enter before these commands are respected. I also want it implemented more like a dead man's switch, perhaps requiring the user to hold the slider in QGC which will then continuously send the test value, rather than sending it once to start, and once to stop.

Thoughts?

@MaEtUgR
Copy link
Member

MaEtUgR commented Dec 10, 2018

should have some kind of special arming state for this that the user has to enter before these commands are respected

makes sense

perhaps requiring the user to hold the slider in QGC which will then continuously send the test value

you mean for the case where connection is lost in the moment something bad happens? Command stream should be necessary and I think holding some key or button to keep it the motor test running would definitely increase safety. And as I wrote I would support a short motor twitch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants