[DO_NOT_MERGE] Fix gz servo angle scale to match joint angles #21439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The gzbridge servo actuators have a scaling between 0 and 1000, which are then converted to a normalized joint angle between [-1. 1] radians which are quite arbitrary. Since the GzBridge controls the joint angles directly through
ignition transport
, it would be nice if we can have the joint angles configurable directly from theCA
interfaceSolution
This commit sets the scaling parameters for gz sim servos to match joint angle values directly
The issue is that the actuator output value type is
uint16_t
and therefore cannot have negative values.@bkueng @dagar Would you have any ideas on how to solve this? The interface seems to be only strictly built for an unsigned datatype