-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32H7 Can Filter & Can bus-off State Handling #21701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline
src/drivers/uavcan/uavcan_drivers/stm32h7/driver/src/uc_stm32h7_can.cpp
Outdated
Show resolved
Hide resolved
src/drivers/uavcan/uavcan_drivers/stm32h7/driver/src/uc_stm32h7_can.cpp
Outdated
Show resolved
Hide resolved
src/drivers/uavcan/uavcan_drivers/stm32h7/driver/src/uc_stm32h7_can.cpp
Outdated
Show resolved
Hide resolved
src/drivers/uavcan/uavcan_drivers/stm32h7/driver/src/uc_stm32h7_can.cpp
Outdated
Show resolved
Hide resolved
@davids5 anything else here to do, except for squash comments? I can confirm the bus is much more stable. We can short the CANH and CANL, and it will recover perfectly. The only thing I am unsure about is the filter implementation. @JacobCrabill do you have comments or suggestion to make? I just @ you due to your work on the initial driver work :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henrykotze LGTM but please squash/Fix it up the commits
72ec93d
to
0259500
Compare
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-community-q-a-july-12-2023/33086/4 |
Exception handling for bus-off state in the STM32H7 driver, and first go at implementing the CAN filters
Based on the following STM32 Documents:
RM0433 - Reference manual for STM32H742, STM32H743/753 and STM32H750 Value line
AN5348 - Introduction to FDCAN peripherals for STM32 product classes
TN1367 - Bus off management in MCAN controllers
Context
Implementation