Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

ecl: check that the range finder data accuracy #473

Closed
wants to merge 2 commits into from
Closed

ecl: check that the range finder data accuracy #473

wants to merge 2 commits into from

Conversation

jiejiezhang
Copy link
Contributor

@jiejiezhang jiejiezhang commented Jul 5, 2018

check that the range finder data accuracy. Replace #472

void Ekf::checkRangeDataAccuracy()
{
// get most recent range measurement from buffer
_rng_data_accuracy_good = _range_buffer.get_newest().variance <= 0.3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an arbitrary magic number.

Copy link
Contributor Author

@jiejiezhang jiejiezhang Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhkabir Yes, If you agree with this scheme, I will add it as a parameter as soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priseborough
Copy link
Collaborator

I am trying to coordinate a number of changes and issues relating to range finder use at the moment:

PX4/PX4-Autopilot#9861
PX4/PX4-Autopilot#9886
PX4/PX4-Autopilot#9865

They will make this PR obsolete.

@priseborough
Copy link
Collaborator

@jiejiezhang PR PX4/PX4-Autopilot#9865 should meet your immediate requirement provided you modify your code so that publisher of the distance sensor topic sets the quality to 0 when the sensor specific checks fail.

Once PX4/PX4-Autopilot#9865 has been merged I will then submit additional PR's to move the checking the of the quality to inside the ecl library and also fix PX4/PX4-Autopilot#9861.

@jiejiezhang
Copy link
Contributor Author

Once PX4/PX4-Autopilot#9865 has been merged I will then submit additional PR's to move the checking the of the quality to inside the ecl library and also fix PX4/PX4-Autopilot#9861.

Thanks very much!!! 👍

@jiejiezhang jiejiezhang deleted the add-check-sonar-quality branch July 13, 2018 05:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants