[Echo] Support more types of prompt echo #4022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AuferGachet
commented
Sep 9, 2025
AuferGachet
commented
- When the prompt type is list[int] or list[list[int]], it needs to support echo after decoding.
…, it needs to support echoing after decoding.
|
Thanks for your contribution! |
…, it needs to support echoing after decoding.
…, it needs to support echoing after decoding.
…, it needs to support echoing after decoding.
LiqinruiG
reviewed
Sep 9, 2025
| request_prompts = [self.engine_client.data_processor.tokenizer.decode(item) for item in request.prompt] | ||
| else: | ||
| request_prompts = request_prompt_ids | ||
| request.prompt = request_prompts |
Collaborator
There was a problem hiding this comment.
不去直接改 request.prompt。 在echo = true 的时候，再去编码。
…, it needs to support echoing after decoding.
…, it needs to support echoing after decoding.
…, it needs to support echoing after decoding.
…, it needs to support echoing after decoding.
…, it needs to support echoing after decoding.
Merge branch 'echo_patch' of https://github.com/AuferGachet/FastDeploy into echo_patch
LiqinruiG
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.