Skip to content

[MTP]support more branchs in topp kernel #4352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2025
Merged

[MTP]support more branchs in topp kernel #4352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions custom_ops/gpu_ops/speculate_decoding/top_p_candidates.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,25 @@ struct BlockPrefixCallbackOp {
} break

#define FIXED_TOPK(...) \
FIXED_TOPK_BASE(1, ##__VA_ARGS__); \
FIXED_TOPK_BASE(2, ##__VA_ARGS__); \
FIXED_TOPK_BASE(3, ##__VA_ARGS__); \
FIXED_TOPK_BASE(4, ##__VA_ARGS__); \
FIXED_TOPK_BASE(5, ##__VA_ARGS__); \
FIXED_TOPK_BASE(6, ##__VA_ARGS__); \
FIXED_TOPK_BASE(7, ##__VA_ARGS__); \
FIXED_TOPK_BASE(8, ##__VA_ARGS__); \
FIXED_TOPK_BASE(10, ##__VA_ARGS__)
FIXED_TOPK_BASE(9, ##__VA_ARGS__); \
FIXED_TOPK_BASE(10, ##__VA_ARGS__); \
FIXED_TOPK_BASE(20, ##__VA_ARGS__); \
FIXED_TOPK_BASE(30, ##__VA_ARGS__); \
FIXED_TOPK_BASE(40, ##__VA_ARGS__); \
FIXED_TOPK_BASE(50, ##__VA_ARGS__); \
FIXED_TOPK_BASE(60, ##__VA_ARGS__); \
FIXED_TOPK_BASE(70, ##__VA_ARGS__); \
FIXED_TOPK_BASE(80, ##__VA_ARGS__); \
FIXED_TOPK_BASE(90, ##__VA_ARGS__); \
FIXED_TOPK_BASE(100, ##__VA_ARGS__);

struct SegmentOffsetIter {
explicit SegmentOffsetIter(int num_cols) : num_cols_(num_cols) {}
Expand Down Expand Up @@ -499,8 +512,9 @@ void DispatchTopK(const T* src,
max_seq_len));
default:
PD_THROW(
"the input data shape has error in the topp_beam_topk "
"kernel.");
"Invalid max_candidate_len. Please set a value in [1,10] (step=1) "
"or [10,100] (step=10)."
);
});
default:
PD_THROW("the input topk is not implemented.");
Expand Down
Loading