Skip to content

Optimization of ‘tools’ in request fields #4380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 20, 2025
Merged

Optimization of ‘tools’ in request fields #4380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
00114c6
Remove multiple 'tools'
AuferGachet Oct 13, 2025
4604314
Remove multiple 'tools'
AuferGachet Oct 14, 2025
46df187
Merge branch 'develop' into qwen3_tool_parser
AuferGachet Oct 14, 2025
1dccf6d
Remove multiple 'tools'
AuferGachet Oct 15, 2025
9756ba1
Merge branch 'qwen3_tool_parser' of https://github.com/AuferGachet/Fa…
AuferGachet Oct 15, 2025
1d34905
Remove multiple 'tools'
AuferGachet Oct 16, 2025
10fdf5e
Merge branch 'develop' into qwen3_tool_parser
AuferGachet Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastdeploy/entrypoints/engine_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ async def add_requests(self, task):
task["preprocess_start_time"] = time.time()
try:
chat_template_kwargs = task.get("chat_template_kwargs") or {}
chat_template_kwargs.update({"chat_template": task.get("chat_template"), "tools": task.get("tools")})
chat_template_kwargs.update({"chat_template": task.get("chat_template")})
task["chat_template_kwargs"] = chat_template_kwargs
if inspect.iscoroutinefunction(self.data_processor.process_request_dict):
await self.data_processor.process_request_dict(task, self.max_model_len)
Expand Down
5 changes: 3 additions & 2 deletions tests/entrypoints/test_engine_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@ async def test_add_request(self):

await self.engine_client.add_requests(request)
assert "chat_template" in request["chat_template_kwargs"], "'chat_template' not found in 'chat_template_kwargs"
assert "tools" in request["chat_template_kwargs"], "'tools' not found in 'chat_template_kwargs'"
# assert "tools" in request["chat_template_kwargs"], "'tools' not found in 'chat_template_kwargs'"
assert request["chat_template_kwargs"]["chat_template"] == "Hello"
assert request["chat_template_kwargs"]["tools"] == [1]
assert request["tools"] == [1]
# assert request["chat_template_kwargs"]["tools"] == [1]


if __name__ == "__main__":
Expand Down
Loading