Skip to content

Conversation

@zeroRains
Copy link
Contributor

@zeroRains zeroRains commented Oct 16, 2025

Motivation

当前缺少一个规范化的PR模板,导致很多PR提交时缺乏可读性,后续问题溯源也很难快速确定当前PR的具体功能是什么。

因此本PR添加了一个PR模板,后续PR需要按照此模板进行相关内容填写,以提高PR的可读性。

Modifications

.github文件夹下添加模板文件pull_request_template.md。

Usage or Command

无用户接口修改

Accuracy Tests

模板规范化,不涉及功能,无需单测。

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Oct 16, 2025

Thanks for your contribution!

@gongshaotian
Copy link
Collaborator

Motivation

当前缺少一个规范化的PR模板,导致很多PR提交时缺乏可读性,后续问题溯源也很难快速确定当前PR的具体功能是什么。

因此本PR添加了一个PR模板,后续PR需要此模板进行相关内容填写,以提高PR的可读性。

Modifications

.github文件夹下添加模板文件pull_request_template.md。

Usage or Command

模板规范化,不涉及功能,无需单测。

Accuracy Tests

模板规范化,不涉及功能,无需单测。

Checklist

  • Add a tag like [BugFix], [CUDAGraph], [EP] in the PR title.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.

Usage or Command 的描述是不是不对

@zeroRains
Copy link
Contributor Author

zeroRains commented Oct 16, 2025

Motivation

当前缺少一个规范化的PR模板,导致很多PR提交时缺乏可读性,后续问题溯源也很难快速确定当前PR的具体功能是什么。
因此本PR添加了一个PR模板,后续PR需要此模板进行相关内容填写,以提高PR的可读性。

Modifications

.github文件夹下添加模板文件pull_request_template.md。

Usage or Command

模板规范化,不涉及功能,无需单测。

Accuracy Tests

模板规范化,不涉及功能,无需单测。

Checklist

  • Add a tag like [BugFix], [CUDAGraph], [EP] in the PR title.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.

Usage or Command 的描述是不是不对

这里的描述是,如果增加新功能就提供使用方法,如果是性能优化或者bug修复提供复现指令

<!-- You should provide the usage if this pr is about the new function. -->
<!-- You should provide the command to run if this pr is about the performance optimization or fixing bug. -->

@zeroRains zeroRains changed the title [Format] add PR Template [Others] add PR Template Oct 16, 2025
@gongshaotian
Copy link
Collaborator

gongshaotian commented Oct 16, 2025

简单优化了一下:[[FDConfig], [APIServer], [Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization],[Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others]]
多硬件:[[XPU], [GCU], [DCU], [HPU], [Iluvatar], [Metax]]

## Checklist

- [ ] Add at least a tag in the PR title.
- Tag list: [`[FDConfig]`,`[APIServer]`,`[Engine]`, `[Scheduler]`, `[PD Disaggregation]`, `[Executor]`, `[Graph Optimization]`, `[Speculative Decoding]`, `[RL]`, `[Models]`, `[Quantization]`, `[Loader]`, `[OP]`, `[BugFix]`, `[Docs]`, `[CI]`, `[Optimization]`, `[Feature]`, `[Benchmark]`, `[Others]`, `[XPU]`, `[HPU]`, `[GCU]`, `[DCU]`, `[Iluvatar]`, `[Metax]`]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@gongshaotian gongshaotian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongshaotian gongshaotian merged commit 5885953 into PaddlePaddle:develop Oct 17, 2025
24 of 27 checks passed
@zeroRains zeroRains deleted the pr branch October 17, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants