-
Notifications
You must be signed in to change notification settings - Fork 660
[Others] add PR Template #4452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Others] add PR Template #4452
Conversation
|
Thanks for your contribution! |
Usage or Command 的描述是不是不对 |
这里的描述是,如果增加新功能就提供使用方法,如果是性能优化或者bug修复提供复现指令
|
|
简单优化了一下:[[FDConfig], [APIServer], [Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization],[Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others]] |
.github/pull_request_template.md
Outdated
| ## Checklist | ||
|
|
||
| - [ ] Add at least a tag in the PR title. | ||
| - Tag list: [`[FDConfig]`,`[APIServer]`,`[Engine]`, `[Scheduler]`, `[PD Disaggregation]`, `[Executor]`, `[Graph Optimization]`, `[Speculative Decoding]`, `[RL]`, `[Models]`, `[Quantization]`, `[Loader]`, `[OP]`, `[BugFix]`, `[Docs]`, `[CI]`, `[Optimization]`, `[Feature]`, `[Benchmark]`, `[Others]`, `[XPU]`, `[HPU]`, `[GCU]`, `[DCU]`, `[Iluvatar]`, `[Metax]`] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
gongshaotian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
当前缺少一个规范化的PR模板,导致很多PR提交时缺乏可读性,后续问题溯源也很难快速确定当前PR的具体功能是什么。
因此本PR添加了一个PR模板,后续PR需要按照此模板进行相关内容填写,以提高PR的可读性。
Modifications
在
.github文件夹下添加模板文件pull_request_template.md。Usage or Command
无用户接口修改
Accuracy Tests
模板规范化,不涉及功能,无需单测。
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.