[BugFix] When the value of "temperature" is 0, adjust it to 1e-06 #4900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Jiang-Jia-Jun
requested changes
Nov 9, 2025
fastdeploy/engine/engine.py
Outdated
| request = Request.from_dict(task) | ||
| llm_logger.info(f"Receive request {request}") | ||
| if sampling_params is not None: | ||
| if sampling_params.temperature is not None and sampling_params.temperature == 0: |
Collaborator
There was a problem hiding this comment.
改成下面判断吧
if abs(sampling_params.temperature) < 1e-06:
sampling_params.temperature = 1e-06
LiqinruiG
changed the title
Jiang-Jia-Jun
previously approved these changes
Nov 9, 2025
luukunn
added a commit
to luukunn/FastDeploy
that referenced
this pull request
Nov 10, 2025
…ddlePaddle#4900) * add default temperature value * add unit test * update * update * add unit test * update * fix unit test
Jiang-Jia-Jun
pushed a commit
that referenced
this pull request
Nov 10, 2025
) * 【DataProcessor】add options thinking_mode (#4735) * add thinking_mode * add thinking_mode * add thinking_mode * add thinking_mode * add thinking_mode * add thinking_mode * add unit test * [BugFix] When the value of "temperature" is 0, adjust it to 1e-06 (#4900) * add default temperature value * add unit test * update * update * add unit test * update * fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.