Skip to content

[CI] Add env ci #5331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EmmonsCurse merged 3 commits into from
Dec 2, 2025
Merged

[CI] Add env ci #5331

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7484a09
test
Wanglongzhi2001 Dec 2, 2025
1f43b65
[CI] Add env ci
Wanglongzhi2001 Dec 2, 2025
3ef0885
test donw
Wanglongzhi2001 Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions scripts/check_approval.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@ if [ "${HAS_SPECULATIVE_DECODING_MODIFY}" != "" ] && [ "${PR_ID}" != "" ]; then
check_approval "$echo_line1" 1 freeliuzc Deleter-D
fi

ENV_FILE="fastdeploy/envs.py"

HAS_ENV_MODIFY=$(git diff upstream/$BRANCH --name-only | grep -E "^${ENV_FILE}$" || true)
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BRANCH is expanded unquoted in the shell command git diff upstream/$BRANCH --name-only, which allows command injection if an attacker can influence the branch name (e.g., a PR from a fork with a branch name containing ; or backticks). This can lead to arbitrary command execution in CI with your secrets (like GITHUB_TOKEN). Quote the variable to prevent the shell from interpreting metacharacters, e.g.,

HAS_ENV_MODIFY=$(git diff "upstream/${BRANCH}" --name-only | grep -E "^${ENV_FILE}$" || true)

Additionally consider validating BRANCH against a safe pattern (e.g., ^[A-Za-z0-9._/-]+$).

Copilot uses AI. Check for mistakes.
if [ "${HAS_ENV_MODIFY}" != "" ] && [ "${PR_ID}" != "" ]; then
echo_line1="You must have one FastDeploy RD (yuanlehome(liuyuanle), rainyfly(chenjian26), Wanglongzhi2001(wanglongzhi)) approval for modifying [${ENV_FILE}]."
check_approval "$echo_line1" 1 yuanlehome rainyfly Wanglongzhi2001
fi

if [[ "${BRANCH}" != "develop" ]] && [[ -n "${PR_ID}" ]]; then
pr_info=$(curl -H "Authorization: token ${GITHUB_TOKEN}" \
https://api.github.com/repos/PaddlePaddle/FastDeploy/pulls/${PR_ID})
Expand Down
Loading