AsyncStreams: Remove the Destroying state

Author: Pagghiu

Libraries/AsyncStreams/AsyncStreams.cpp

@@ -191,12 +191,6 @@ void AsyncReadableStream::emitOnData()
 
 void AsyncReadableStream::push(AsyncBufferView::ID bufferID, size_t newSize)
 {
-    if (state == State::Destroying)
-    {
-        eventClose.emit();
-        state = State::Destroyed;
-        return;
-    }
     if (newSize == 0)
     {
         emitError(Result::Error("AsyncReadableStream::push zero sized buffer is not allowed"));
@@ -323,15 +317,11 @@ void AsyncReadableStream::destroy()
     case State::Paused:
     case State::Pausing:
     case State::Reading:
-        state = State::Destroyed;
-        eventClose.emit();
-        break;
     case State::AsyncPushing:
     case State::AsyncReading:
-        // Must wait for async read to finish
-        state = State::Destroying;
+        state = State::Destroyed;
+        eventClose.emit();
         break;
-    case State::Destroying: emitError(Result::Error("AsyncReadableStream::destroy - already destroying")); break;
     case State::Destroyed: emitError(Result::Error("AsyncReadableStream::destroy - already destroyed")); break;
     case State::Ended: emitError(Result::Error("AsyncReadableStream::destroy - already ended")); break;
     case State::Stopped: emitError(Result::Error("AsyncReadableStream::destroy - already stopped")); break;
@@ -390,10 +380,6 @@ void AsyncReadableStream::pushEnd()
         eventEnd.emit();
         eventClose.emit();
         break;
-    case State::Destroying:
-        eventClose.emit();
-        state = State::Destroyed;
-        break;
     case State::Destroyed: emitError(Result::Error("AsyncReadableStream::pushEnd - stream is destroyed")); break;
     case State::Ended: emitError(Result::Error("AsyncReadableStream::pushEnd - stream already ended")); break;
     case State::Stopped: emitError(Result::Error("AsyncReadableStream::pushEnd - stream is not even inited")); break;

Libraries/AsyncStreams/AsyncStreams.h

@@ -239,7 +239,6 @@ struct AsyncReadableStream
         Pausing,      // Pause requested while read in flight
         Paused,       // Actually paused with no read in flight
         Ended,        // Emitted all data, no more data will be emitted
-        Destroying,   // Readable is waiting for async call before
         Destroyed,    // Readable has been destroyed before emitting all data
         Errored,      // Error occurred
     };