Skip to content

Introduction of the parameters Dmin and Dmax, which regulate the input image dimensions into the model #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2023
Merged

Introduction of the parameters Dmin and Dmax, which regulate the input image dimensions into the model #15

merged 2 commits into from
Oct 3, 2023

Conversation

@TheEverglow
Copy link
Contributor

Introduction of the parameters Dmin and Dmax, which regulate the input image dimensions into the model

Pandede
Pandede requested changes Oct 3, 2023
View reviewed changes
Copy link
Owner

@Pandede Pandede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Here is a final suggestion:

  1. Rename Dmin to dim_min and Dmax to dim_max, for matching the autopep8 linting.

@Pandede Pandede merged commit 036739a into Pandede:master Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pandede Pandede Pandede approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheEverglow @Pandede