-
-
Notifications
You must be signed in to change notification settings - Fork 557
Description
I think the type naming is inconsistent, with itself, and with other aspects of the existing API. To be clear, I don't care which we go with, but I do feel that consistency is important for an API (not as big a deal for the impl). The API uses z instead of s in types already, like FertilizeEggEvent and oxidized relating to copper. The API isn't consistent with itself already, like Effect#OXIDISED_COPPER_SCRAPE but I feel like we should push for consistency in all new things.
Also, the term RegionisedScheduler doesn't seem to mesh with GlobalRegionScheduler and EntityScheduler. Those aren't GlobalisedRegionScheduler or EntitisedScheduler. I think the names for different schedulers should be RegionScheduler, GlobalScheduler, and EntityScheduler removing this problem with s and z in the first place.