Skip to content

Clarify API naming scheme #2

@Machine-Maker

Description

@Machine-Maker

I think the type naming is inconsistent, with itself, and with other aspects of the existing API. To be clear, I don't care which we go with, but I do feel that consistency is important for an API (not as big a deal for the impl). The API uses z instead of s in types already, like FertilizeEggEvent and oxidized relating to copper. The API isn't consistent with itself already, like Effect#OXIDISED_COPPER_SCRAPE but I feel like we should push for consistency in all new things.

Also, the term RegionisedScheduler doesn't seem to mesh with GlobalRegionScheduler and EntityScheduler. Those aren't GlobalisedRegionScheduler or EntitisedScheduler. I think the names for different schedulers should be RegionScheduler, GlobalScheduler, and EntityScheduler removing this problem with s and z in the first place.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions