adventure: make calls with generic component lists more usable#9008
Merged
kennytv merged 1 commit intoPaperMC:masterfrom Mar 20, 2023
Merged
adventure: make calls with generic component lists more usable#9008kennytv merged 1 commit intoPaperMC:masterfrom
kennytv merged 1 commit intoPaperMC:masterfrom
Conversation
This should allow the usage of ItemStack#lore and other methods with a List<TextComponent>
Machine-Maker
approved these changes
Mar 20, 2023
kennytv
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow the usage of methods with a List parameter like ItemStack#lore with a List.
Sometimes API methods will return TextComponents so you'd have to parse to get List.
This api change is backwards compatible unless plugins are implementing Player, ItemStack and ItemMeta.