Resolve Plugin Dependency Issues, Improve PluginLoading Compat, Small Loading Issues#9068
Merged
electronicboy merged 5 commits intoPaperMC:masterfrom Apr 9, 2023
Merged
Conversation
Owen1212055
changed the title
Owen1212055
added
the
publish-pr
Member
Author
|
This is now ready for review. This now fixes symbolic link issues + dotted prefixes loading. |
|
Test build posted in this pr works like a charm! Addons for our plugin now load without any issues. Thanks @Owen1212055 ! |
|
thanks for the pr! now mbedwars loads fine for me |
electronicboy
approved these changes
Apr 8, 2023
|
last version i tried was this one: Edit: With the version mentioned in the OP Thread i could load / unload and reload the plugins with when the dependency is allready loaded. i tried it with a plugin called MobFarmManager. That has a hard dependency called CMILIB |
Member
Author
|
This has been tested to confirm that this does resolve issues related to plugman. |
|
Might have broken something. See Andre601/AdvancedServerList#81 |
na this logs more like a placeholder api issie |
Contributor
|
Yes this broke my plugin loading a protocollib class, too. |
Member
Author
|
This caused some issues with paper plugin dependency loading and will propetly looked into in a future PR. 👍 |
|
Verified fixed with reversion of the changes in Paper 1.19.4-507. Thanks. |
fixed? Does the loading, unloading and reloading works now if a plugin has dependencies?.... i just see issues in log with the 507 now when a players logs in and also with some plugins. and also some plugins trow error in 507 like this well im not sure if this was because of changes in 504, 505 506 or 507.. but it was 505 the one i saw this issue with in log. |
Member
|
that CMI error is unrelated to plugin loading, upstream changed internals, plugins that use internals to respawn stuff instead of the api will break because of that, the fix is to no longer use internals |
506/507 made that come to light, but 503 which I used before and when I downgrade to it - it all still works with cmi, so something did change somehow, even if cmi did things wrong. zrips is working on a potential fix, but that's all I know. With 506+ the user skin wont show, they don't show ingame, or in tablist for the user who logged in, while others see it okay, and the on join errors. But I have no idea if it's some spigot upstream change, spigot or whatever ~here to sharing my experience and results of some testing. |
Member
Author
|
The skin list not showing and the CMI issues are not related to this PR in any way. This was intended to fix loading plugins with dependencies using the api, however this needed to be reverted due to issues with loading it caused. |
|
i still hope the find a solution in current build the issue is back Build 509 i also can repduce the error on loading of a plugin with depenceny with 508 and 507 in 506 it was loading fine. |
|
so will there be a new "fix" that we could load aggain the plugins? or do we need to stay at the Build 506 now? ;O |
Member
|
yes, we obviously still want to fix the issue that this PR aimed to address (notice how the issue was reopened after the revert of this PR), but due to the complicated nature of all this, we will not rush it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes: #9005
Fixes: #8971, #9057
Pass dependency tree when loading, this allows us to correctly resolve dependencies when loading while plugins already in the plugin manager.
Download the paperclip jar for this pull request: paper-9068.zip