Make sidebar resizable #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds resizable sidebar functionality to the diff viewer using the paneforge library. Users can now manually adjust the sidebar width by dragging a resize handle, with the layout state persisted in cookies across sessions.
- Integrates paneforge library for split pane layout with resizable sidebar
- Implements layout state persistence via cookies for sidebar width
- Adds keyboard shortcut (Ctrl/Cmd+B) to toggle sidebar visibility
- Refactors sidebar positioning logic to work within the paneforge layout system
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| web/package.json | Adds paneforge@1.0.2 dependency for resizable panes |
| web/src/lib/layout.svelte.ts | New LayoutState class managing sidebar width, collapse state, and layout persistence |
| web/src/lib/util.ts | Adds setCookie and clearCookie helper functions for layout persistence |
| web/src/lib/keybinds.svelte.ts | Renames getModifierKey to formatModifierKey (private) and adds formatModifierBind for consistent keybind formatting |
| web/src/lib/global-options.svelte.ts | Uses new setCookie utility function instead of inline cookie setting |
| web/src/lib/diff-viewer.svelte.ts | Integrates LayoutState and registers Ctrl/Cmd+B keybind for sidebar toggle |
| web/src/routes/+layout.svelte | Moves GlobalOptions.init from page to layout for earlier initialization |
| web/src/routes/+page.server.ts | New server load function to retrieve persisted layout state from cookies |
| web/src/routes/+page.svelte | Replaces manual sidebar positioning with PaneGroup/Pane/PaneResizer components |
| web/src/routes/Sidebar.svelte | Simplifies sidebar component by removing positioning logic and click-outside handling |
| web/src/routes/FileHeader.svelte | Updates to use layoutState.sidebarCollapsed |
| web/src/lib/components/SidebarToggle.svelte | Moved from routes/ and updated to use layoutState.toggleSidebar() |
| web/src/lib/components/menu-bar/MenuBar.svelte | Adds "Toggle Sidebar" and "Reset Layout" menu items, includes SidebarToggle in menubar |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jpenilla
force-pushed
the
feat/resizable-sidebar
branch
from
64d2c59 to
c5ee5b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows resizing the sidebar while maintaining the same general layout and sidebar left/right positioning ability.
Known issue:
When opening a new window with an existing layout cookie for a different sized window, the absolute sidebar size will change as only proportions are persisted. There is a TODO in the code with more details, but fixing this properly needs changes in paneforge to support setting a size in px for SSR.