Skip to content

feat(notebooks): require projectId to fork notebook N-39 #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 2, 2020
Merged

feat(notebooks): require projectId to fork notebook N-39 #329

merged 3 commits into from
Nov 2, 2020

Conversation

@e-r-i-k-a
Copy link
Contributor

@e-r-i-k-a e-r-i-k-a commented Oct 29, 2020 •
edited
Loading

https://linear.app/paperspace/issue/N-39/make-projectid-a-required-parameter-to-fork-in-the-cli

QA test plan:

  1. try to fork a notebook without a projectId and fail 😿
  2. create a project, note id
  3. try to fork a notebook with projectId and succeed 😸
  4. confirm that the notebook is in fact in that project via notebooks details

tallyw00d
tallyw00d approved these changes Nov 2, 2020
View reviewed changes
Copy link

@tallyw00d tallyw00d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following scenarios worked. LGTM :shipit:

  1. try to fork a notebook without a projectId and fail 😿
  2. create a project, note id
  3. try to fork a notebook with projectId and succeed 😸
  4. confirm that the notebook is in fact in that project via notebooks details

@e-r-i-k-a e-r-i-k-a merged commit 8cbef23 into master Nov 2, 2020
@e-r-i-k-a e-r-i-k-a deleted the erika/n-39-make-projectid-a-required-parameter-to branch November 2, 2020 21:25
@PSBOT
Copy link

PSBOT commented Nov 2, 2020

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@PSBOT PSBOT added the released label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbatha bbatha bbatha approved these changes

@tallyw00d tallyw00d tallyw00d approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@e-r-i-k-a @PSBOT @bbatha @tallyw00d