Added Lorenz attractor problem #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 68.50% // Head: 68.66% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 68.50% 68.66% +0.15%
==========================================
Files 226 229 +3
Lines 19510 19643 +133
==========================================
+ Hits 13365 13487 +122
- Misses 6145 6156 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
|
Looks really good to me! As usual, it looks all very clean coded. But there is one thing I noticed: Due to consistency it makes sense to rename the file Lorentz.py to Lorenz.py ;) That's all! |
Member
|
Merged it. You could consider testing the MPI part or removing it (if you don't need it anyway). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple script that solves the non-linear equations implicitly. I also added a scipy reference solution analogously to the van der Pol problem. I used this reference solution to verify the implementation of the Jacobian. The solution also has the familiar butterfly shape.
I tried to write everything such that the changes going to v6 will be minimal, that is to say I already put in defaults instead of essential keys.
I added a hook for computing the global error at the end of the run. Because the step sizes get redistributed between the last
post_stephook and thepost_runhook, this is a bit more messy than anticipated, but it is also tested.@lisawim, now is your turn to point out the many places where I can improve ;)