-
Notifications
You must be signed in to change notification settings - Fork 37
qmat switch
#445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qmat switch
#445
Conversation
|
Great work, thanks a lot. Taking the quadrature stuff out of pySDC is a very good idea and I appreciate your work. |
|
Not sure why you're obscuring this PR with so much renaming, though.. this makes it much harder to see what actually happens here. |
|
Is there a reason why the CI pipeline is back to 40+minutes now? Or is that a GitHub glitch? I see no obvious cause. |
Well, this was a big change anyway, and the naming of the core classes has been confusing me since a long time ... so that's mostly shooting two birds with one stone. |
Understood. As a preference, I think smaller PRs with a clear focus are better, though. |
|
And no, this is not stopping me from merging this, of course! |
I guessed 😅 ... but don't worry, I'll stick to smaller PR with one dedicated topic from now. Also in my opinion, it would make sense to drop a new release after the PR is merged. |
|
For sure and already on my todo list! |
Probably a GitHub glitch ... but project testing still take quite some time (especially the |
|
Unless this will significantly shorten the CI time, I'd rather have broad coverage. |
Probably not, since most are run in parallel ... just significantly less computation ressource used (mostly energy saving) |
After implementing most of the core coefficients generation of
pySDCintoqmat, here is the associated PR finalizing the switch mentioned in #436.Main changes :
LagrangeApproximationandNodeGeneratorclasses (and their associated tests) are now inqmatCollBaseclass is now mostly an interface to theCollocationclass fromqmatSweeperclass produces implicit and explicit QDelta matrices usingqmatgeneratorspipdependency forpySDCset toqmat>=0.1.8qmatdocumentation when neededAdditional changes :
parallelSDCproject has been patch by removing testing (and coverage) of the plotting function forpreconditioner_playground_MPI. If this PR is accepted, no need to merge Some fixes for the newnumpy2.0 version. #443 anymore as it was already merged in this PR.Sweeper.get_qDelta_implicitandSweeper.get_qDelta_explicitonly have one argument now :qd_type. The previouscollone was simply replaced byself.coll, as noSweeperinstance inpySDCcode use anotherCollocationclass as the base underlying collocation for the sweeper. This was a weird mix between OOP and Procedural Programming that does not make sense but rather the code more complex than it should be.Hookclass (see https://github.com/tlunet/pySDC/commit/32f64bf032119f989c9302c3c077d1cb4fc07de8, I won't even try to understand the idea behind this sort of attribute ...)