Perform at least one SDC iteration #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Well. Not the first time we're running into this, but I'm not sure this is actually a bug. It depends on how you count, but if the prediction is good enough, why iterate? Take a problem that is constant for some time, then the prediction is already fine. |
Contributor
Author
|
The problem is that the solution will remain constant forever in this case unless there is some time-dependent forcing. |
Member
|
True, if the prediction is just 0 or copy. |
Contributor
Author
|
Ok, so if you use non-default prediction or random, you don't need to do iterations...? |
Member
|
I think I'd rather agree on always doing a single iteration (at least) instead of distinguishing this here. So, I'd be ok with your first approach. |
brownbaerchen
added a commit
to brownbaerchen/pySDC
that referenced
this pull request
Dec 26, 2024
* Perform at least one SDC iteration * Can use only prediction if predicting exotically * Reverted last commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abdel and I were running into issues from time to time when the SDC residual of the prediction was low enough proclaim convergence. In this case, the code just does not do anything anymore but counting up the time and returning this solution.
I would consider this a bug.
The fix here is a bit weird because in single level SDC the sweep and iterations variables are interchangeable. Do you see any problem with doing it like this @pancetta?