Fixing Firedrake tests #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firedrake recently had some major changes to its installation. It can now be installed much easier with pip and I believe the Python does not have to be managed by Firedrake anymore. The Docker image was changed significantly to reflect that, breaking our tests.
This PR updates our tests to accommodate the changes. Note that I had to make some tolerances less tight. I have noticed before that changing the Python version changes roundoff errors and I assume that this is behind why I had to do had.
Please remember to squash and merge and replace the commit message with something shorter than the default..