Deprecated failing gusto test #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to deprecate one test of the Gusto integration that uses space-time parallelism. I found it very hard to debug since I could not replicate the failure locally with a fresh installation of both firedrake and gusto. On GitHub, the test was flaky, sometimes passing, sometimes giving an incorrect result, but mostly just deadlocking somewhere.
Since this test used to pass and now somehow broke, I will come back to this in a couple of weeks and see if it fixed itself. But for now, I am afraid, I have to just remove the test. There are still tests running the same configuration with space-only and time-only parallelism. Just no longer space-time-parallel..