Feature/switch for coll update #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 22, 2015 09:38
…rue (default), a proper collocation update is performed in compute_end_point. If False, the stage corresponding to the end point is copied. Throws an exception of set to False for collocation nodes where endpoint is not a stage
…alse for collocation object with right_is_node=False
…stage; can now switch between collocation update and copy be setting do_coll_update as sweeper parameter
pancetta
added a commit
that referenced
this pull request
Dec 22, 2015
Feature/switch for coll update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it seems that for some reason copying the last stage instead of performing a full update improves stability, this introduces a flag
do_coll_updateas a sweeper parameter which can be set toFalseto do a simple copy of the last stage incompute_end_value.The default is
True, that is to perform a proper update. An exception is raised ifdo_coll_update=Falsefor a set of nodes where the right endpoint is not a quadrature node.Tests verify that (a) the exception is raised as expected and (b) that the update is identical to
q*Uwithq=(0,...,0,1).