Skip to content

Conversation

@brownbaerchen
Copy link
Collaborator

Only changed function names and documentation. Functionality remains the same.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9a9e5f8) to head (14fc218).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1425      1429    +4     
=========================================
+ Hits          1425      1429    +4     
Flag Coverage Δ
smart-tests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlunet
Copy link
Member

tlunet commented Jul 22, 2025

Don't forget the jupyter notebooks 😉

@tlunet
Copy link
Member

tlunet commented Jul 22, 2025

Also : maybe keep the alias for the method name, using

getDerivationMatrix = getDerivativeMatrix

just after the method's definition in the class (for backward compatibility and legacy ...)

@brownbaerchen
Copy link
Collaborator Author

Also : maybe keep the alias for the method name, using

getDerivationMatrix = getDerivativeMatrix

just after the method's definition in the class (for backward compatibility and legacy ...)

Is this really necessary? Is anyone apart from you currently using this feature?

@tlunet
Copy link
Member

tlunet commented Jul 22, 2025

Nice for the deprecation warning, I'll remove it at some point. And yes : there are some codes in some places where I use it, and Sebastian used it too for the FNO

@tlunet tlunet merged commit 391e608 into Parallel-in-Time:main Jul 22, 2025
6 checks passed
@brownbaerchen brownbaerchen deleted the spelling branch July 22, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants