-
Notifications
You must be signed in to change notification settings - Fork 12
Add SPM support #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPM support #68
Conversation
|
@cwisecarver, any chance of getting this PR looked at soon? Our team plans to integrate soon, and we'd love to have SPM support from the start. |
|
@BetweenTwoBits @eddie-zhang Could you provide a brief description to the PR / comment of how we can verify this change works and doesn't cause regressions? |
|
This PR only provides the package.swift file which is needed by SPM. The repo would need to have releases tagged with git tags in addition, in order to support SPM. I don't believe package.swift is used by anything other than SPM so I don't see it causing a regression. |
|
Thanks @eddie-zhang! Could you point to a guide that outlines how to implement the below (and any other requirements needed to support SPM)?
|
|
Thanks @eddie-zhang. The release is here: https://github.com/Parsely/AnalyticsSDK-iOS/releases/tag/0.2.1. Let me know if that works for you! |
|
@abelsonlive why close the PR rather than merge it? I think we'd all assume that you'd keep supporting people implementing via SPM |
|
@BetweenTwoBits I added support via: c1a3bd0. It was faster to make the commit myself than request changes. Here's the release: https://github.com/Parsely/AnalyticsSDK-iOS/releases/tag/0.2.1 |
| @@ -0,0 +1,28 @@ | |||
| // swift-tools-version:5.3 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @abelsonlive -- there's a fatal error in Xcode when integrating with SPM because of this missing line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @eddie-zhang, we've got separate work on-going to add SPM support. I've reverted these commits for now. I'll @ you on the PR once we're ready to merge it.
No description provided.