Skip to content

Conversation

@eddie-zhang
Copy link

No description provided.

@BetweenTwoBits
Copy link

@cwisecarver, any chance of getting this PR looked at soon? Our team plans to integrate soon, and we'd love to have SPM support from the start.

@abelsonlive
Copy link
Contributor

abelsonlive commented Apr 4, 2023

@BetweenTwoBits @eddie-zhang Could you provide a brief description to the PR / comment of how we can verify this change works and doesn't cause regressions?

@eddie-zhang
Copy link
Author

This PR only provides the package.swift file which is needed by SPM. The repo would need to have releases tagged with git tags in addition, in order to support SPM. I don't believe package.swift is used by anything other than SPM so I don't see it causing a regression.

@abelsonlive
Copy link
Contributor

abelsonlive commented Apr 4, 2023

Thanks @eddie-zhang! Could you point to a guide that outlines how to implement the below (and any other requirements needed to support SPM)?

The repo would need to have releases tagged with git tags in addition, in order to support SPM

@eddie-zhang
Copy link
Author

@abelsonlive
Copy link
Contributor

Thanks @eddie-zhang. The release is here: https://github.com/Parsely/AnalyticsSDK-iOS/releases/tag/0.2.1. Let me know if that works for you!

@abelsonlive abelsonlive closed this Apr 5, 2023
@BetweenTwoBits
Copy link

@abelsonlive why close the PR rather than merge it? I think we'd all assume that you'd keep supporting people implementing via SPM

@abelsonlive
Copy link
Contributor

abelsonlive commented Apr 5, 2023

@BetweenTwoBits I added support via: c1a3bd0. It was faster to make the commit myself than request changes.

Here's the release: https://github.com/Parsely/AnalyticsSDK-iOS/releases/tag/0.2.1

@@ -0,0 +1,28 @@
// swift-tools-version:5.3
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @abelsonlive -- there's a fatal error in Xcode when integrating with SPM because of this missing line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @eddie-zhang, we've got separate work on-going to add SPM support. I've reverted these commits for now. I'll @ you on the PR once we're ready to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants