Skip to content

Relax a couple of time assertions in unit tests #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Relax a couple of time assertions in unit tests #79

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7665e37
Wait slightly longer for the test expectation to be fulfilled
crazytonyli Apr 23, 2023
84392b5
Add `accuracy` parameter to compare two double variables
crazytonyli Apr 23, 2023
038ac60
Merge branch 'master' into relax-unit-test-time-assertions
crazytonyli Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions Tests/SamplerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ class SamplerTests: ParselyTestCase {
Timer.scheduledTimer(withTimeInterval: heartbeatDeliveryInterval, repeats: false) { timer in
expectation.fulfill()
}
waitForExpectations(timeout: heartbeatDeliveryInterval, handler: nil)
// Wait slightly longer to reduce the race between waiting for the `expectation` to be
// fulfilled and the fulfillment.
waitForExpectations(timeout: heartbeatDeliveryInterval + 0.01, handler: nil)

let actualUpdatedInterval = samplerUnderTest!.heartbeatInterval
// This value depends on heartbeatInterval, and two magic numbers in the implementation.
Expand Down Expand Up @@ -160,8 +162,12 @@ class SamplerTests: ParselyTestCase {

let accumulatedTime:TimeInterval = samplerUnderTest!.accumulators["sampler-test"]!.accumulatedTime
samplerUnderTest!.pause()
XCTAssert(accumulatedTime >= assertionTimeout - acceptableDifference,
"The sampler should accumulate time constantly after a call to trackKey")
XCTAssertEqual(
accumulatedTime,
assertionTimeout,
accuracy: acceptableDifference,
"The sampler should accumulate time constantly after a call to trackKey"
)

let secondExpectation = self.expectation(description: "Paused sampling")
Timer.scheduledTimer(withTimeInterval: assertionTimeout, repeats: false) { timer in
Expand All @@ -170,6 +176,11 @@ class SamplerTests: ParselyTestCase {
waitForExpectations(timeout: assertionTimeout + acceptableDifference, handler: nil)

let secondAccumulatedTime: TimeInterval = samplerUnderTest!.accumulators["sampler-test"]!.accumulatedTime
XCTAssert(secondAccumulatedTime <= assertionTimeout, "AccumulatedTime was \(secondAccumulatedTime)")
XCTAssertEqual(
secondAccumulatedTime,
assertionTimeout,
accuracy: acceptableDifference,
"AccumulatedTime was \(secondAccumulatedTime)"
)
}
}