Add lots of simple type annotations throughout parsl/dataflow #2414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comes from the benc-mypy branch The benc-mypy branch contains some more complicated situations, which are not merged by this PR.
…nt to be a simple PR
benclifford
added a commit
that referenced
this pull request
Oct 1, 2025
Prior to PR #2514, tasks were removed at completion when checkpointed, rather than when completed, in the case that checkpointing was enabled. This was race-y behaviour and was removed in PR #2414. This test also looks like it is subject to a related race condition around task completion, described in issue #1279, for which there is a sleep statement - this PR does not modify that but does add a reference to the issue.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
Prior to PR #2514, tasks were removed at checkpoint-completion when checkpointed, rather than when completed, in the case that checkpointing was enabled. This was race-y behaviour and was removed in PR #2414. This test also looks like it is subject to a related race condition around task completion, described in issue #1279, for which there is a sleep statement - this PR does not modify that but does add a reference to the issue. # Changed Behaviour none ## Type of change - Code maintenance/cleanup
benclifford
added a commit
that referenced
this pull request
Oct 1, 2025
Prior to PR #2514, tasks were removed at completion when checkpointed, rather than when completed, in the case that checkpointing was enabled. This was race-y behaviour and was removed in PR #2414. This test also looks like it is subject to a related race condition around task completion, described in issue #1279, for which there is a sleep statement - this PR does not modify that but does add a reference to the issue.
benclifford
added a commit
that referenced
this pull request
Oct 7, 2025
Prior to PR #2514, tasks were removed at completion when checkpointed, rather than when completed, in the case that checkpointing was enabled. This was race-y behaviour and was removed in PR #2414. This test also looks like it is subject to a related race condition around task completion, described in issue #1279, for which there is a sleep statement - this PR does not modify that but does add a reference to the issue.
benclifford
added a commit
that referenced
this pull request
Oct 15, 2025
Prior to PR #2514, tasks were removed at completion when checkpointed, rather than when completed, in the case that checkpointing was enabled. This was race-y behaviour and was removed in PR #2414. This test also looks like it is subject to a related race condition around task completion, described in issue #1279, for which there is a sleep statement - this PR does not modify that but does add a reference to the issue.
benclifford
added a commit
that referenced
this pull request
Oct 16, 2025
Prior to PR #2514, tasks were removed at completion when checkpointed, rather than when completed, in the case that checkpointing was enabled. This was race-y behaviour and was removed in PR #2414. This test also looks like it is subject to a related race condition around task completion, described in issue #1279, for which there is a sleep statement - this PR does not modify that but does add a reference to the issue.
benclifford
added a commit
that referenced
this pull request
Oct 17, 2025
Prior to PR #2514, tasks were removed at completion when checkpointed, rather than when completed, in the case that checkpointing was enabled. This was race-y behaviour and was removed in PR #2414. This test also looks like it is subject to a related race condition around task completion, described in issue #1279, for which there is a sleep statement - this PR does not modify that but does add a reference to the issue.
benclifford
added a commit
that referenced
this pull request
Oct 17, 2025
Prior to PR #2514, tasks were removed at completion when checkpointed, rather than when completed, in the case that checkpointing was enabled. This was race-y behaviour and was removed in PR #2414. This test also looks like it is subject to a related race condition around task completion, described in issue #1279, for which there is a sleep statement - this PR does not modify that but does add a reference to the issue.
benclifford
added a commit
that referenced
this pull request
Oct 17, 2025
Prior to PR #2514, tasks were removed at completion when checkpointed, rather than when completed, in the case that checkpointing was enabled. This was race-y behaviour and was removed in PR #2414. This test also looks like it is subject to a related race condition around task completion, described in issue #1279, for which there is a sleep statement - this PR does not modify that but does add a reference to the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from the benc-mypy branch
The benc-mypy branch contains some more complicated situations,
which are not merged by this PR.
Type of change