Skip to content

Conversation

@weralabaj
Copy link
Contributor

Reverts #491

@mikeminutillo
Copy link
Member

Doing a deeper investigation I came across this.

Whenever we construct (at least in v4.6 on NServiceBus) a TransportMessage the TimeSent header is filled in to UtcNow. https://github.com/Particular/NServiceBus/blob/support-4.6/src/NServiceBus.Core/TransportMessage.cs#L32

That means when we ingest an error that does not have that error set here, it is set to the time of ingestion.

It should never be null.

@weralabaj
Copy link
Contributor Author

@WolfByte Exactly it was done in Jan 2014. But this is only applied for outgoing messages (see usages of this constructor), the problem is for messages coming from external systems to NSB.

weralabaj pushed a commit that referenced this pull request Aug 4, 2015
Revert "Return nulls when TimeSent is missing"
@weralabaj weralabaj merged commit 8e9371a into develop Aug 4, 2015
@johnsimons johnsimons deleted the revert-491-FeatureDev_issue_194 branch August 5, 2015 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants