Skip to content

Failed messages to display UNKNOWN when data is missing instead of blank or min date #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2015
Merged

Failed messages to display UNKNOWN when data is missing instead of blank or min date #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91f5c61
handle datetime.minvalue
Jul 21, 2015
cee57dc
Handle missing message type value. Display 'Message Type Unknown - mi…
Jul 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ServicePulse.Host/app/js/directives/moment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,18 @@ angular.module('directives.moment', [])
return {
restrict: 'E',
link: function(scope, element, attrs) {
var minDate = "0001-01-01T00:00:00";
var timeoutId = null;
var m;

attrs.$observe('date', function (value) {
if (value) {
if (value && attrs.date !== minDate) {
m = moment(attrs.date);
element.attr('title', m.format('LLLL'));
updateText();
updateLoop();
} else {
element.text('TimeSent value unknown');
}
});

Expand Down
2 changes: 1 addition & 1 deletion src/ServicePulse.Host/app/js/failed_messages/failedMessages.tpl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ <h2 class="failedMessages-header"><i class="fa fa-envelope"></i><span class="bre
<a eat-click tooltip="This only works if ServiceInsight is installed." class="btn btn-small btn-link" ng-click="debugInServiceInsight($index)"><i class="icon-service-insight"></i> Open in ServiceInsight</a>
</div>
<div class=" row-fluid">
<div class="span10 rowText" title="Message Type: {{row.message_type}}">{{row.message_type | limitTo: 90}}<span ng-show="row.message_type.length > 90">...</span></div>
<div class="span10 rowText" title="Message Type: {{row.message_type}}">{{row.message_type || 'Message Type Unknown - missing metadata EnclosedMessageTypes' | limitTo: 90}}<span ng-show="row.message_type.length > 90">...</span></div>
<div class="span2 text-right"><sp-moment date="{{row.time_sent}}" /></div>
</div>
<div class="row-fluid">
Expand Down