Skip to content

Bumping mininum supported Service Control version #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2024
Merged

Bumping mininum supported Service Control version #1842

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f47169
Bump mininum supported Service Control version
cquirosj May 5, 2024
b441263
deep check environment var to trigger toast
cquirosj May 6, 2024
f3dd66c
removed unused parameter
cquirosj May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/Frontend/src/composables/serviceServiceControl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const monitoringConnectionState = reactive<ConnectionState>({
export const environment = reactive({
monitoring_version: "",
sc_version: "",
minimum_supported_sc_version: "1.39.0",
minimum_supported_sc_version: "4.33.4",
is_compatible_with_sc: true,
sp_version: window.defaultConfig && window.defaultConfig.version ? window.defaultConfig.version : "1.1.0",
supportsArchiveGroups: false,
Expand Down Expand Up @@ -183,12 +183,10 @@ export async function useServiceControlConnections() {
return connections;
}

watch(environment, (newValue, oldValue) => {
if (newValue.is_compatible_with_sc !== oldValue.is_compatible_with_sc) {
if (!newValue.is_compatible_with_sc) {
useShowToast(TYPE.ERROR, "Error", `You are using Service Control version ${newValue.sc_version}. Please, upgrade to version ${newValue.minimum_supported_sc_version} or higher to unlock new functionality in ServicePulse.`);
}
}
watch(() => environment.is_compatible_with_sc, (newValue) => {
if (newValue == false) {
useShowToast(TYPE.ERROR, "Error", `You are using Service Control version ${environment.sc_version}. Please, upgrade to version ${environment.minimum_supported_sc_version} or higher to unlock new functionality in ServicePulse.`);
}
});

async function getServiceControlVersion() {
Expand Down