If ServiceControl Api Uri is configured with or without a trailing slash the application will now behave properly #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the application will behave properly
petersgiles
changed the title
Contributor
Author
|
@johnsimons @colin-higgins please review |
Member
|
@petersgiles at first it scared me the ammount of code changed to fix a missing backspash. Just for future, is there a way to test this ? |
Contributor
Author
|
@johnsimons we need to look at a test framework perhaps karma but I've never run one up in anything other than gulp. Dunno how it would all work with team city etc. |
petersgiles
pushed a commit
that referenced
this pull request
Oct 30, 2015
…sh-on-servicecontrol-uri If ServiceControl Api Uri is configured with or without a trailing slash the application will now behave properly
petersgiles
deleted the
fix-inconsistent-trailing-slash-on-servicecontrol-uri
branch
Contributor
|
I've set up javascript tests in TeamCity before, I can get that up for us soon. We'd use a headless browser like PhantomJS to run the tests. PhantomJS is just an executable that you feed some arguments to, easy to add as a step in TeamCity. For running the tests in visual studio, I've used Chutzpah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #200
If there is a trailing slash on the end of the ServiceControl api uri in the config file ServicePulse would compensate for it inappropriately. Now if the config has a trailing slash or not ServicePulse will be able to handle it.