Message retries failing and Endpointconfiguration not updating #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@johnsimons do you want to review? |
Member
|
The change looks good but I saw lots of notification commented out:
Are we not providing any feedback to the user ? |
Contributor
Author
|
@johnsimons those notifications have been replaced by all those animations. I need to clean those commented items up. |
Member
|
@petersgiles I don't see anything odd with it but maybe @colin-higgins could give it another set of eyes |
petersgiles
pushed a commit
that referenced
this pull request
Nov 4, 2015
…point-problems Message retries failing and Endpointconfiguration not updating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#202 #203